This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #489 and somewhat solves #356
Allows you to use sapper with an API service residing in another server. This is especially useful if your API server is written in another language.
This solution also allows you to use private internal hostnames when fetching data for better latency (since the request doesn't have to hit the externally-facing load balancer). It also works if fetching data from multiple domains (though I don't imagine that's the common case it seemed better not to prevent it)
I was questioning the best API for this. An alternate API might be two options: a function which rewrites URLs to fetch and a function that decides whether to include credentials. I'm open to other ideas as well and happy to implement anything that makes sense