chore: yarn to pnpm #334

baseballyama · 2023-05-14T06:21:44Z

close: #333

changeset-bot · 2023-05-14T06:21:46Z

🦋 Changeset detected

Latest commit: 9e2d388

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte-eslint-parser	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coveralls · 2023-05-14T06:29:41Z

Pull Request Test Coverage Report for Build 4971008653

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.777%

Totals
Change from base Build 4927073925:	0.0%
Covered Lines:	2105
Relevant Lines:	2243

💛 - Coveralls

baseballyama

I took a diff for lib dir between main branch and this branch, and only difference is the comment which is the word yarn and pnpm.

baseballyama · 2023-05-14T06:22:34Z

.eslintrc.js

@@ -69,6 +69,7 @@ module.exports = {
        "@typescript-eslint/no-use-before-define": "off",
        "@typescript-eslint/no-explicit-any": "off",
        "no-implicit-globals": "off",
+        "no-void": ["error", { allowAsStatement: true }],


I'm not sure why suddenly ESLint error occurs but I needed to add this.

baseballyama · 2023-05-14T06:30:24Z

.github/workflows/NodeCI.yml

  test:
    runs-on: ubuntu-latest
    strategy:
      matrix:
-        node-version: [12.x, 14.x, 16.x, 17.x, 18.x, 19.x]
+        node-version: [14.x, 16.x, 17.x, 18.x, 19.x]


I dropped Node 12 because pnpm 7 doesn't support it.
Can we do this?

How about creating a test-for-node12 job and using pnpm v6?

test-for-node12: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - uses: pnpm/action-setup@v2 with: version: 6.35.1

If it still doesn't work, let's drop support for node v12.
Since this package is still at 0.x, I believe it can contain breaking changes in minor versions.

ota-meshi

Thank you for this PR!

ota-meshi · 2023-05-14T07:42:57Z

.github/workflows/GHPages.yml

@@ -28,12 +28,12 @@ jobs:
      - uses: actions/setup-node@v3


I think pnpm/action-setup is necessary.

Suggested change

- uses: actions/setup-node@v3

- uses: pnpm/action-setup@v2

- uses: actions/setup-node@v3

I couldn't do this perfectly😇
fixed!
92a644b

ota-meshi · 2023-05-14T07:43:15Z

.github/workflows/NodeCI.yml

  test:
    runs-on: ubuntu-latest
    strategy:
      matrix:
-        node-version: [12.x, 14.x, 16.x, 17.x, 18.x, 19.x]
+        node-version: [14.x, 16.x, 17.x, 18.x, 19.x]


How about creating a test-for-node12 job and using pnpm v6?

test-for-node12: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - uses: pnpm/action-setup@v2 with: version: 6.35.1

If it still doesn't work, let's drop support for node v12.
Since this package is still at 0.x, I believe it can contain breaking changes in minor versions.

ota-meshi · 2023-05-14T07:45:00Z

.github/workflows/Release.yml

@@ -27,16 +27,16 @@ jobs:
          node-version: 16

      - name: Install Dependencies
-        run: yarn
+        run: pnpm install


I think pnpm/action-setup is necessary.

I couldn't do this perfectly😇
fixed!
92a644b

.github/workflows/NodeCI.yml

ota-meshi · 2023-05-14T08:09:17Z

Hmm. It seems that v6 and v7 handle command line arguments differently.

https://raulmelo.dev/en/blog/migrating-from-pnpm-6-to-7#running-a-script

ota-meshi · 2023-05-14T08:10:56Z

Let's drop support for Node v12 😄

ota-meshi

Thank you very much!

baseballyama added 2 commits May 14, 2023 14:40

install pnpm and simple replace

e7cb3c9

fix a few issues

e962620

baseballyama force-pushed the chore/pnpm branch from 50bdbe4 to 19eee5d Compare May 14, 2023 06:25

fix github actions

3519024

baseballyama force-pushed the chore/pnpm branch from 19eee5d to 3519024 Compare May 14, 2023 06:26

drop Node 12

bcb33d1

adjust deps version

d3c5d21

baseballyama force-pushed the chore/pnpm branch from 1aca3f0 to d3c5d21 Compare May 14, 2023 06:36

baseballyama commented May 14, 2023

View reviewed changes

baseballyama marked this pull request as ready for review May 14, 2023 06:38

baseballyama requested a review from ota-meshi May 14, 2023 06:38

ota-meshi requested changes May 14, 2023

View reviewed changes

more pnpm

92a644b

baseballyama force-pushed the chore/pnpm branch 2 times, most recently from f9abea9 to 3702dcc Compare May 14, 2023 07:56

ota-meshi reviewed May 14, 2023

View reviewed changes

.github/workflows/NodeCI.yml Outdated Show resolved Hide resolved

back Node 12

226f1e1

baseballyama force-pushed the chore/pnpm branch from 884ff7b to 226f1e1 Compare May 14, 2023 08:01

drop Node 12 again

9e2d388

baseballyama requested a review from ota-meshi May 14, 2023 08:14

ota-meshi approved these changes May 14, 2023

View reviewed changes

ota-meshi merged commit fa4adf6 into sveltejs:main May 14, 2023

github-actions bot mentioned this pull request May 14, 2023

chore: release svelte-eslint-parser #336

Merged

baseballyama mentioned this pull request May 14, 2023

Use pnpm or update package.json #333

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: yarn to pnpm #334

chore: yarn to pnpm #334

baseballyama commented May 14, 2023 •

edited

Loading

changeset-bot bot commented May 14, 2023 •

edited

Loading

coveralls commented May 14, 2023 •

edited

Loading

baseballyama left a comment

baseballyama May 14, 2023

baseballyama May 14, 2023

ota-meshi May 14, 2023

ota-meshi left a comment

ota-meshi May 14, 2023

baseballyama May 14, 2023

ota-meshi May 14, 2023

ota-meshi May 14, 2023

baseballyama May 14, 2023

ota-meshi commented May 14, 2023

ota-meshi commented May 14, 2023

ota-meshi left a comment

	- uses: actions/setup-node@v3
	- uses: pnpm/action-setup@v2
	- uses: actions/setup-node@v3

chore: yarn to pnpm #334

chore: yarn to pnpm #334

Conversation

baseballyama commented May 14, 2023 • edited Loading

changeset-bot bot commented May 14, 2023 • edited Loading

🦋 Changeset detected

coveralls commented May 14, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4971008653

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

baseballyama left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ota-meshi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ota-meshi commented May 14, 2023

ota-meshi commented May 14, 2023

ota-meshi left a comment

Choose a reason for hiding this comment

baseballyama commented May 14, 2023 •

edited

Loading

changeset-bot bot commented May 14, 2023 •

edited

Loading

coveralls commented May 14, 2023 •

edited

Loading