only apply key to keyed each block, not its children - fixes #1202

sveltejs · Mar 5, 2018 · 7b4c486 · 7b4c486
1 parent 3554908
commit 7b4c486
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/generators/dom/Block.ts b/src/generators/dom/Block.ts
@@ -163,7 +163,7 @@ export default class Block {
 	}
 
 	child(options: BlockOptions) {
-		return new Block(Object.assign({}, this, options, { parent: this }));
+		return new Block(Object.assign({}, this, { key: null }, options, { parent: this }));
 	}
 
 	contextualise(expression: Node, context?: string, isEventHandler?: boolean) {

diff --git a/test/runtime/samples/if-in-keyed-each/_config.js b/test/runtime/samples/if-in-keyed-each/_config.js
@@ -0,0 +1,15 @@
+export default {
+	data: {
+		items: [
+			{ id: 1, name: 'one' },
+			{ id: 2, name: 'two' }
+		]
+	},
+
+	html: `
+		<ul>
+			<li>one</li>
+			<li>two</li>
+		</ul>
+	`
+};
diff --git a/test/runtime/samples/if-in-keyed-each/main.html b/test/runtime/samples/if-in-keyed-each/main.html
@@ -0,0 +1,7 @@
+<ul>
+	{{#each items as item @id}}
+		{{#if item.id}}
+			<li>{{item.name}}</li>
+		{{/if}}
+	{{/each}}
+</ul>