Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML5 attributes parsing #1772

Closed
mrkishi opened this issue Oct 16, 2018 · 1 comment · Fixed by #1776
Closed

HTML5 attributes parsing #1772

mrkishi opened this issue Oct 16, 2018 · 1 comment · Fixed by #1776

Comments

@mrkishi
Copy link
Member

mrkishi commented Oct 16, 2018

Svelte's attribute parser does not match html5 specs.

As an example, this should work and properly validates, but svelte refuses to parse it:
https://svelte.technology/repl?version=2.13.5&gist=890eadcdeaa2ac0130463565aa3ede4c

This will most likely affect people using html minifiers before compiling their components.
Rich-Harris added a commit that referenced this issue Oct 17, 2018
@Rich-Harris
include solidus in attribute values - fixes #1772
9e07e3f
@Rich-Harris Rich-Harris mentioned this issue Oct 17, 2018
Merged
Rich-Harris added a commit that referenced this issue Oct 20, 2018
@Rich-Harris
Merge pull request #1776 from sveltejs/gh-1772
9e899db 
include solidus in attribute values
@Rich-Harris
Copy link
Member

Fixed in 2.14.1, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include solidus in attribute values sveltejs/svelte
2 participants
@mrkishi @Rich-Harris