-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property "muted" for <audio> and <video> #2998
Comments
Yes please! A PR for |
Hi guys, may I enquire about the state of this PR @fend25 or @Conduitry as I'd love to have the use of |
Draft PR for this, but it needs some fixing before it's good. #4690 |
Hello. Is there any progress on this PR?
|
Sorry, I guess this means we've been officially bitten by not having a separate branch to deploy docs from. This feature is in master, as are its docs, but it hasn't been released yet. The docs just came along when I was deploying some other documentation fixes from master. This should be released soon. |
This has been released in 3.23.0. |
Hello!
Now
<audio>
and<video>
components provide 3 two-way binding tags:currentTime
,paused
andvolume
.I'd like to send a PR with the
muted
property.This property is not the same as setting
volume
to 0. It has slightly different mechanics and in some cases is really needed (i.e. modern browsers disallow autoplay non-muted video. setting volume to 0 doesnt work).Also it is useful in some scenarios (i. e. if we want to make volume controller like youtube one, where you can mute sound by the button, and the volume slider is still visible and showing volume level, which would be actual after unmutting)
Is this PR welcome?
PS. commit is already in my fork: fend25@a37ee81
(there are some unrelated linting fixes - I did the linting)
The text was updated successfully, but these errors were encountered: