We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new import deconflicting in 1.7.1 does not appear to be working correctly with shared helpers. I'm running
svelte.compile('anything', { shared: true })
and this is outputting code that begins with
import { get, fire, observe, on, set, _flush, dispatchObservers, createElement, detachNode, insertNode, createText, appendNode, noop, get, fire, observe, on, set, _flush } from "svelte/shared.js"
Several named imports are being included twice.
The text was updated successfully, but these errors were encountered:
shared: true
Ah, of course — it's because as of 76663f9, helpers are added to generator.uses here, meaning they're being duplicated here.
generator.uses
Aside from that, have just realised that dispatchObservers isn't being handled the same way as other helpers.
dispatchObservers
Sorry, something went wrong.
svelte/src/generators/dom/index.js
Line 366 in a861043
generator.uses should probably be merged with that existing array.
edit: I was a little too slow on that Comment button 😄
prevent duplicate imports (#308)
6d66213
Merge pull request #314 from sveltejs/gh-308
54445fa
prevent duplicate imports
Successfully merging a pull request may close this issue.
The new import deconflicting in 1.7.1 does not appear to be working correctly with shared helpers. I'm running
and this is outputting code that begins with
Several named imports are being included twice.
The text was updated successfully, but these errors were encountered: