Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydration removes <title> element #4310

Closed
Conduitry opened this issue Jan 23, 2020 · 1 comment · Fixed by #4311
Closed

Hydration removes <title> element #4310

Conduitry opened this issue Jan 23, 2020 · 1 comment · Fixed by #4311
Labels
bug

Comments

@Conduitry
Copy link
Member

Describe the bug
When starting from SSR generated HTML with hydratable: true, hydration will remove the <title> element along with the other appropriate <head> elements, but will not add it back.

Logs
None.

To Reproduce
https://github.com/johnmuhl/svelte-hydrate-head

Expected behavior
The <title> should remain after hydration.

Stacktraces
None.

Information about your Svelte project:
Independent of browser.
Svelte 3.17.0+

Severity
Pretty bad.

Additional context
This was introduced in #4082. The compiled component sets document.title first and then later removes elements matching [data-svelte="svelte-..."], and so the title is lost. The simplest way to handle this would probably be to not add the special SSR attribute to the <title> element at all, since as of #4250 we don't need to worry about there being more than one of that anyway.

cc @johnmuhl @tanhauhau
@Conduitry Conduitry added the bug label Jan 23, 2020
Conduitry added a commit to Conduitry/sveltejs_svelte that referenced this issue Jan 23, 2020
@Conduitry
do not attach SSH <head> markers to <title> (sveltejs#4310)
b4d36e7
Conduitry added a commit to Conduitry/sveltejs_svelte that referenced this issue Jan 23, 2020
@Conduitry
do not attach SSR <head> markers to <title> (sveltejs#4310)
c6c6316
@Conduitry Conduitry mentioned this issue Jan 23, 2020
Merged
@Conduitry
Copy link
Member Author

Fixed in 3.17.3.

@ghost ghost mentioned this issue Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix hydration of <title> Conduitry/sveltejs_svelte
1 participant
@Conduitry