Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding broken on <select> within optgroup #915

Closed
bsssshhhhhhh opened this issue Nov 8, 2017 · 1 comment · Fixed by #925
Closed

Binding broken on <select> within optgroup #915

bsssshhhhhhh opened this issue Nov 8, 2017 · 1 comment · Fixed by #925

Comments

@bsssshhhhhhh
Copy link
Contributor

bsssshhhhhhh commented Nov 8, 2017 •
edited
Loading

2-way binding is broken on <option> elements that are nested within an <optgroup> tag:
https://svelte.technology/repl?version=1.41.2&gist=29dbb2651b80d111672cd74944b4bf57

Instead of "World", the value is set to undefined
Rich-Harris added a commit that referenced this issue Nov 14, 2017
@Rich-Harris
dont use innerHTML for options inside optgroups - fixes #915
d28942d
@Rich-Harris Rich-Harris mentioned this issue Nov 14, 2017
Merged
Rich-Harris added a commit that referenced this issue Nov 18, 2017
@Rich-Harris
Merge pull request #925 from sveltejs/gh-915
3ff208f 
don't use innerHTML for options inside optgroups
@Rich-Harris
Copy link
Member

Fixed in 1.41.4. Thanks!

sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this issue Dec 24, 2024
@dummdidumm
fix: add polyfills / avoid using structuredClone (sveltejs#915)
0d2d24f 
- polyfills for `at` and `withResolvers`
- avoid using `structuredClone`, we can use `JSON.parse(JSON.stringify(..))` instead at that position

makes the site work in more browsers

closes sveltejs#911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't use innerHTML for options inside optgroups sveltejs/svelte
2 participants
@Rich-Harris @bsssshhhhhhh