You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#924 changed things round a bit, such that more analysis takes place in one go, at the start of the compilation process, rather than piecemeal later on through generator.contextualise. This means more stuff is shared between the DOM and SSR compilers, for example.
Now that that's done, it might be good to get rid of generator.contextualise altogether — it's a bit of a strange beast, doing analysis and code transformation at the same time in a way that's a little inscrutable. My hunch is that things would become a bit simpler as a result.
My hunch could be wrong through — there are basically three phases (walkTemplate, which is compiler-agnostic, preprocess, which is compiler-specific and sets things up for the final phase, and lastly the actual code generation). It might well turn out that we can't put more stuff into walkTemplate because it depends on work that necessarily happens later.
Regardless, I'll leave this issue here to remind myself to look into it if I feel sufficiently motivated.
The text was updated successfully, but these errors were encountered:
#924 changed things round a bit, such that more analysis takes place in one go, at the start of the compilation process, rather than piecemeal later on through
generator.contextualise
. This means more stuff is shared between the DOM and SSR compilers, for example.Now that that's done, it might be good to get rid of
generator.contextualise
altogether — it's a bit of a strange beast, doing analysis and code transformation at the same time in a way that's a little inscrutable. My hunch is that things would become a bit simpler as a result.My hunch could be wrong through — there are basically three phases (
walkTemplate
, which is compiler-agnostic,preprocess
, which is compiler-specific and sets things up for the final phase, and lastly the actual code generation). It might well turn out that we can't put more stuff intowalkTemplate
because it depends on work that necessarily happens later.Regardless, I'll leave this issue here to remind myself to look into it if I feel sufficiently motivated.
The text was updated successfully, but these errors were encountered: