Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise <title> #1053

Merged
merged 3 commits into from
Dec 30, 2017
Merged

optimise <title> #1053

merged 3 commits into from
Dec 30, 2017

Conversation

Rich-Harris
Copy link
Member

fixes #1027

@codecov-io
Copy link

codecov-io commented Dec 24, 2017

Codecov Report

Merging #1053 into master will decrease coverage by 0.35%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   92.03%   91.67%   -0.36%     
==========================================
  Files         121      123       +2     
  Lines        4393     4456      +63     
  Branches     1416     1437      +21     
==========================================
+ Hits         4043     4085      +42     
- Misses        148      157       +9     
- Partials      202      214      +12
Impacted Files Coverage Δ
src/generators/nodes/index.ts 100% <ø> (ø) ⬆️
...generators/server-side-rendering/visitors/index.ts 100% <ø> (ø) ⬆️
src/validate/html/validateHead.ts 60% <100%> (+60%) ⬆️
src/validate/html/validateElement.ts 90% <100%> (+0.63%) ⬆️
...generators/server-side-rendering/visitors/Title.ts 100% <100%> (ø)
src/generators/Generator.ts 93.84% <57.14%> (-0.68%) ⬇️
src/generators/nodes/Title.ts 60.46% <60.46%> (ø)
src/generators/dom/Block.ts 96.42% <0%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ec514...a8f7d57. Read the comment docs.

@Conduitry
Copy link
Member

Does this update the handling of all instances of <title>, not just those that appear in <:Head>? I haven't tried, but it looks like it would. I'm not sure whether that's desirable, or whether there are any valid reasons to want a <title> element elsewhere inserted the old fashioned way - apart from what I'm assuming is the special case for SVG stuff.

@Rich-Harris
Copy link
Member Author

Good catch, thank you. Fixed

@Rich-Harris Rich-Harris merged commit 0df6cfa into master Dec 30, 2017
@Rich-Harris Rich-Harris deleted the gh-1027 branch December 30, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise <title>
3 participants