Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: markdown runtime errors/warnings #11304

Merged
merged 6 commits into from
Apr 24, 2024
Merged

chore: markdown runtime errors/warnings #11304

merged 6 commits into from
Apr 24, 2024

Conversation

Rich-Harris
Copy link
Member

This is #11302 but for runtime warnings. Doesn't have a huge impact since we don't actually have many runtime warnings (yet?), but it makes them look a bit nicer:

image

In prod, it just logs the code. In future, it can log a link to the docs.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c09f923

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris changed the title chore: markdown runtime warnings chore: markdown runtime errors/warnings Apr 24, 2024
@Rich-Harris Rich-Harris mentioned this pull request Apr 24, 2024
Closed
7 tasks
dummdidumm
dummdidumm reviewed Apr 24, 2024
View reviewed changes
packages/svelte/src/internal/client/runtime.js Outdated
@@ -880,12 +875,16 @@ export function is_signal(val) {
* @returns {T}
*/
export function getContext(key) {
const context_map = get_or_init_context_map();
if (current_component_context === null) {
e.lifecycle_outside_component('getContext');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not move this logic into get_or_init_context_map? i.e. you give that function the 'getContext' string and it will then invoke the error correctly. Should minify a bit better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, fair. made that change

@Rich-Harris Rich-Harris merged commit 94b4268 into main Apr 24, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the runtime-warnings branch April 24, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @dummdidumm