Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade acorn and parse as ES2018 #1182

Merged
merged 1 commit into from
Feb 23, 2018
Merged

upgrade acorn and parse as ES2018 #1182

merged 1 commit into from
Feb 23, 2018

Conversation

Conduitry
Copy link
Member

There are a few different places where we're parsing with Acorn. I think it makes sense to parse as ES2018 in each place apart from src/generators/dom/index.ts which I think has to do with shared helpers. It might make sense to abstract this out somewhere so we don't have to remember to update as many places each year.

@Conduitry
Copy link
Member Author

cc @jacwright From my brief tests on this branch, spread operators work fine both in the <script> tag and in the template.

@codecov-io
Copy link

codecov-io commented Feb 22, 2018

Codecov Report

Merging #1182 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files         127      127           
  Lines        4572     4572           
  Branches     1495     1495           
=======================================
  Hits         4195     4195           
  Misses        159      159           
  Partials      218      218
Impacted Files Coverage Δ
src/parse/read/script.ts 100% <ø> (ø) ⬆️
src/parse/read/expression.ts 100% <ø> (ø) ⬆️
src/parse/read/directives.ts 73.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8330f32...8c1f09d. Read the comment docs.

@Rich-Harris Rich-Harris merged commit b3b5e6c into master Feb 23, 2018
@Rich-Harris Rich-Harris deleted the upgrade-acorn-es2018 branch February 23, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants