Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only apply key to keyed each block, not its children #1204

Merged
merged 2 commits into from
Mar 5, 2018
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #1202. This bug essentially resulted from the fact that we're not using params any more internally. Nulling out key for blocks that don't specify one is an easy way to ensure the argument isn't added erroneously.

@Rich-Harris Rich-Harris merged commit 0599b5f into master Mar 5, 2018
@Rich-Harris Rich-Harris deleted the gh-1202 branch March 5, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if inside keyed each - state is undefined
2 participants