Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw mustaches #124

Merged
merged 2 commits into from
Dec 6, 2016
Merged

Raw mustaches #124

merged 2 commits into from
Dec 6, 2016

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Dec 5, 2016

Support tripple mustaches, aka raw html output.
I’m a bit disappointed that I had to use <noscript> tags an anchors here. The insertAdjacentHTML API only exists for Element nodes and not for comments.

There is a kind-of precedent for using <noscript> in this way, since older React releases used to use empty <noscript> tags for components returning null in render().

Fixes #35.

@codecov-io
Copy link

codecov-io commented Dec 5, 2016

Current coverage is 91.19% (diff: 95.83%)

Merging #124 into master will increase coverage by 0.08%

@@             master       #124   diff @@
==========================================
  Files            50         51     +1   
  Lines          1362       1386    +24   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1241       1264    +23   
- Misses          121        122     +1   
  Partials          0          0          

Powered by Codecov. Last update def48e2...91903cb

@Swatinem Swatinem mentioned this pull request Dec 5, 2016
@Rich-Harris Rich-Harris merged commit 4a89354 into master Dec 6, 2016
@Rich-Harris Rich-Harris deleted the raw-mustaches branch December 6, 2016 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants