-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate Component
to ReturnType<typeof Component>
in TS
#13656
Conversation
🦋 Changeset detectedLatest commit: 7fb4fd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
What are your thoughts on #13441. Merging that and instead of |
I think it could be interesting...is the language server returning the same type also for legacy components? If i remember they use a different type right @dummdidumm ? Would this type work in that case? |
@paoloricciuti AFAIK everything is of type |
commit: |
commit: |
Svelte 5 rewrite
Closes #13491
I added the migration only for TS because with JSDoc would be immensely more complex (unless i'm missing something) because we would basically need to parse the JSDoc comment ourselves.
WDYT?
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint