Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate Component to ReturnType<typeof Component> in TS #13656

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #13491

I added the migration only for TS because with JSDoc would be immensely more complex (unless i'm missing something) because we would basically need to parse the JSDoc comment ourselves.

WDYT?

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 7fb4fd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FoHoOV
Copy link
Contributor

FoHoOV commented Oct 18, 2024

What are your thoughts on #13441. Merging that and instead of ReturnType<typeof Component> use ComponentExports<typeof Component>.

@paoloricciuti
Copy link
Member Author

What are your thoughts on #13441. Merging that and instead of ReturnType<typeof Component> use ComponentExports<typeof Component>.

I think it could be interesting...is the language server returning the same type also for legacy components? If i remember they use a different type right @dummdidumm ? Would this type work in that case?

@FoHoOV
Copy link
Contributor

FoHoOV commented Oct 24, 2024

@paoloricciuti AFAIK everything is of type Component, it has the legacy types in it for now.

Copy link

pkg-pr-new bot commented Oct 31, 2024

pnpm add https://pkg.pr.new/svelte@13656

commit: 7fb4fd1

Copy link

pkg-pr-new bot commented Oct 31, 2024

pnpm add https://pkg.pr.new/svelte@13656

commit: 6b65293

@dummdidumm dummdidumm merged commit 4715dfa into main Oct 31, 2024
10 checks passed
@dummdidumm dummdidumm deleted the migrate-component-type branch October 31, 2024 11:59
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration: Add correct type for bind:this of Components when using the migration script
3 participants