Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a component.outro method #1449

Closed
wants to merge 2 commits into from
Closed

Add a component.outro method #1449

wants to merge 2 commits into from

Conversation

Rich-Harris
Copy link
Member

I'm actually not certain that we need this, though I'm just going to leave it here anyway. I was thinking about #1211, but outroing nested components wouldn't be done with a public outro method (no sense in creating a ton of Promise objects unnecessarily, it would all happen behind the scenes with callbacks), so essentially this change would add extra bytes for the sake of being able to outro a component programmatically, which I'm not sure is a common need.

@codecov-io
Copy link

codecov-io commented May 12, 2018

Codecov Report

Merging #1449 into master will decrease coverage by 0.1%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   91.09%   90.99%   -0.11%     
==========================================
  Files         122      122              
  Lines        4492     4496       +4     
  Branches     1406     1411       +5     
==========================================
- Hits         4092     4091       -1     
  Misses        158      158              
- Partials      242      247       +5
Impacted Files Coverage Δ
src/compile/nodes/Component.ts 92.82% <0%> (-1.67%) ⬇️
src/compile/dom/index.ts 95.31% <66.66%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1bcfa...d3e812e. Read the comment docs.

@Conduitry Conduitry deleted the gh-1211 branch April 29, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants