-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] run tests with SSR compiler, where possible #253
Conversation
Is the WIP marking tests as client only and skipping them in the SSR tests? I can go through and do that, if you want. |
@PaulBGD not sure to be honest! I made a start on this but then had to work on some other stuff, so I haven't looked into the various ways the tests might fail. In some cases they might even indicate a bug, so I wasn't ready to just mark them as invalid without digging further — but if you're able to look into them that'd be awesome 👍 😀 |
@Rich-Harris Just opened #261 that works on skipping tests that shouldn't be ran on SSR. |
[WIP] Skip some client tests for SSR
So then what's left is
|
Codecov Report
Continue to review full report at Codecov.
|
Added a separate issue for the component two-way binding bug: #275 |
As suggested in #248, runs the DOM compiler tests with the SSR compiler. Doesn't make sense in all cases (e.g.
onrender
doesn't run, in an SSR context), so we'll probably need some kind of 'skip this test' flag, but it should help our coverage a bit