Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] run tests with SSR compiler, where possible #253

Merged
merged 10 commits into from
Feb 1, 2017

Conversation

Rich-Harris
Copy link
Member

As suggested in #248, runs the DOM compiler tests with the SSR compiler. Doesn't make sense in all cases (e.g. onrender doesn't run, in an SSR context), so we'll probably need some kind of 'skip this test' flag, but it should help our coverage a bit

@PaulBGD
Copy link
Member

PaulBGD commented Jan 18, 2017

Is the WIP marking tests as client only and skipping them in the SSR tests? I can go through and do that, if you want.

@Rich-Harris
Copy link
Member Author

@PaulBGD not sure to be honest! I made a start on this but then had to work on some other stuff, so I haven't looked into the various ways the tests might fail. In some cases they might even indicate a bug, so I wasn't ready to just mark them as invalid without digging further — but if you're able to look into them that'd be awesome 👍 😀

@PaulBGD
Copy link
Member

PaulBGD commented Jan 23, 2017

@Rich-Harris Just opened #261 that works on skipping tests that shouldn't be ran on SSR.

@PaulBGD
Copy link
Member

PaulBGD commented Jan 24, 2017

So then what's left is

  • raw-mustaches test should have an equivalent SSR version and we skip the generator one
  • two way binding needs to be fixed for the server
  • server needs to be able to handle yield in a top-level component
  • text-node-top-level gets compiled without the SSR compiler for some reason.. that needs to be fixed. I tried to debug it for 20 minutes and I couldn't figure it out.

@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@d5648df).


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5648df...b8790d1. Read the comment docs.

@Rich-Harris
Copy link
Member Author

Added a separate issue for the component two-way binding bug: #275

@Rich-Harris Rich-Harris merged commit 17e31df into master Feb 1, 2017
@Rich-Harris Rich-Harris deleted the universal-tests branch February 1, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants