-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug events #3005
Debug events #3005
Conversation
@Rich-Harris Not to be a bother, but any chance you can review this sometime soon? I can't move forward with svelte-devtools without it. |
Codecov Report
@@ Coverage Diff @@
## master #3005 +/- ##
=======================================
Coverage 50.25% 50.25%
=======================================
Files 1 1
Lines 197 197
=======================================
Hits 99 99
Misses 98 98 Continue to review full report at Codecov.
|
Thanks so much for this PR, and sincere apologies for the length of time it's taken to review it (once the PR backlog grows past a certain size I fall into the trap of prioritising 'quick wins' and urgent bug fixes over more structural things that require more attention. I know that's annoying for everyone else, and I'm trying to get better at it 😬). This all looks great to me. I've brought it up to date with the current master. I made one change — since merging #3148 we now have an If you're good with that change, then I believe this is ready to merge. |
Looks great. Thanks for the review |
Perfect — released 3.12.0. Thanks again |
This pull request causes code bundles generated with the
dev
flag on to emit events on document when various things happen.It also adds a
Component.$unsafe_set
function that allows any state to be set from outside of the component.This would open up the possibility for tools to be created that "plug into" svelte. One such tools is Svelte DevTools that I've been working on. Another might be a svelte aware testing framework.
See also #2931