Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline $$invalidate calls #3533

Merged
merged 5 commits into from
Sep 8, 2019
Merged

inline $$invalidate calls #3533

merged 5 commits into from
Sep 8, 2019

Conversation

Rich-Harris
Copy link
Member

fixes #3512. This is an alternative to #3532 — it's definitely not as elegant, as PRs go, but it means we can eliminate a decent chunk of code, and should handle some funky edge cases around destructuring assignments.

Still a bit of tidying up to do — it should be possible to remove some more lines of code, as there's currently some duplication between Expression.ts and render_dom/index.ts.

@codecov-io
Copy link

codecov-io commented Sep 8, 2019

Codecov Report

Merging #3533 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3533   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files           1        1           
  Lines         197      197           
=======================================
  Hits           99       99           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f5961...21e0213. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loss of reactivity upon assignment in the condition
3 participants