Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store bindings in each blocks #3534

Merged
merged 7 commits into from
Sep 8, 2019
Merged

Conversation

btk5h
Copy link
Contributor

@btk5h btk5h commented Sep 8, 2019

Fixes #3455. Preserves some additional info from the each block binding in order to generate a store mutation instead of a normal assignment expression.

@codecov-io
Copy link

codecov-io commented Sep 8, 2019

Codecov Report

Merging #3534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3534   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files           1        1           
  Lines         197      197           
=======================================
  Hits           99       99           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f5961...ab3b12b. Read the comment docs.

@Rich-Harris Rich-Harris merged commit fafb390 into sveltejs:master Sep 8, 2019
@Rich-Harris
Copy link
Member

this is amazing, thank you!

@btk5h btk5h deleted the gh-3455 branch September 8, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store binding inside each is broken
3 participants