fix window bindings to store #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Nov 1, 2019
| @@ -127,7 +127,11 @@ export default class WindowWrapper extends Wrapper { | |||
|
|
|||
| component.partly_hoisted.push(b` | |||
| function ${id}() { | |||
| ${props.map(prop => b`$$invalidate('${prop.name}', ${prop.name} = @_window.${prop.value});`)} | |||
| ${props.map(prop => | |||
There was a problem hiding this comment.
If possible, it would be good to use the Component#invalidate() helper to generate this. It has logic built into it to .set() on stores and $$invalidate() for non-stores. Same below with the online binding.
Conduitry
reviewed
Nov 2, 2019
| @@ -0,0 +1,133 @@ | |||
| import { | |||
There was a problem hiding this comment.
Is this js test testing for anything in particular that the other runtime test doesn't cover? In general, we like to avoid having tests for particular js output if possible, because they need to be updated when there are changes to the generated code, and runtime tests continue to just work.
There was a problem hiding this comment.
to take snapshot of the generated output?
I thought it would be great to have both snapshot test and behaviour test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3832
global.window = windowto be able to access the window object from global to pass the test.on a side note, i see a lot of test got
skip=truedue tojsdom, has the jsdom bug fixed?