Handle slot updates where parent component has many variables #4078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No related issue because the problem and solution only revealed themselves in the making of this PR.
Basically, in a situation like this...
...where the parent component has enough dynamic variables that it needs to use an array of bitmasks, the
{foo}
in the slot doesn't get updated. That's because the function that merges the slot scope with the ambient scope is doing bitwise operations on arrays.This PR fixes it. I can't pretend it's the most elegant piece of code ever written, but short of a more comprehensive change to the order of operations, it's probably about as good as we can get.