Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add await catch shorthand #4490

Merged
merged 4 commits into from
Apr 20, 2020

Conversation

tanhauhau
Copy link
Member

Related to #4473

@Conduitry
Copy link
Member

Since we now have this PR, I don't think I'm going to necessarily reject this adding syntax outright, but it has come up before in #3623.

@tanhauhau
Copy link
Member Author

Oops I didn't know about that discussion... And adding the syntax in wasn't that complicated, especially we've allowed empty then body

@Conduitry
Copy link
Member

Locally I merged the latest master into this branch and re-ran tests, a few of them failed, which I haven't looked into.

@tanhauhau tanhauhau force-pushed the tanhauhau/await-catch-shorthand branch from 0727c80 to 634bad9 Compare March 15, 2020 23:52
@Conduitry Conduitry merged commit 77ec48d into sveltejs:master Apr 20, 2020
@tanhauhau tanhauhau deleted the tanhauhau/await-catch-shorthand branch April 20, 2020 13:27
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants