-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid binding event handler callbacks, version 2 #456
Conversation
…t tests for codegen. add test for #433
Taking the WIP label off this now. Event handlers are hoisted to the top level if a) they're not custom events (which can't be hoisted), and b) they're inside an {{#each veryLongList as item}}
<button on:click='set({ selected: item })'>{{item}}</button>
{{/each}} ...the Custom event handlers are no longer bound — because they're declared inside a block where they have access to the node in question, references to |
#449, but on top of #453. Got a bit sidetracked into refactoring the
Element
visitor code, so haven't actually started on the event handler stuff per se, but that'll come soon. Element stuff is starting to feel a bit more logical and easier to follow.