Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix select bind:value when option value change #5054

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #5051

port the same logic from bind:value to value={value}

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@tanhauhau
Copy link
Member Author

no idea why need to cache <select value>, last questioned was in #3723, where the TODO was added, traced further than that yield not much insights.

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5051 branch from a1fcbf0 to 0174c1a Compare June 23, 2020 11:07
@Conduitry Conduitry merged commit 6289dfc into sveltejs:master Jun 23, 2020
@tanhauhau tanhauhau deleted the tanhauhau/gh-5051 branch June 24, 2020 07:30
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Select> does not show the correct initial option if <options> are loaded asynchronously
2 participants