-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow passing in context in constructor #6032
Merged
Conduitry
merged 9 commits into
sveltejs:master
from
tanhauhau:tanhauhau/set-context-in-constructor
Mar 31, 2021
Merged
allow passing in context in constructor #6032
Conduitry
merged 9 commits into
sveltejs:master
from
tanhauhau:tanhauhau/set-context-in-constructor
Mar 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhauhau
force-pushed
the
tanhauhau/set-context-in-constructor
branch
from
February 27, 2021 18:45
8d6c9af
to
a7d66ac
Compare
Rich-Harris
approved these changes
Feb 27, 2021
Conduitry
reviewed
Mar 1, 2021
Do we want a way to do this for SSR components as well? |
That make sense, let me add for SSR components as well. |
tanhauhau
force-pushed
the
tanhauhau/set-context-in-constructor
branch
from
March 2, 2021 07:15
ee65224
to
993a783
Compare
The new SSR test is failing, which I can also reproduce locally. I'm not sure what's going on there. It does pass if I add |
Conduitry
reviewed
Mar 2, 2021
tanhauhau
force-pushed
the
tanhauhau/set-context-in-constructor
branch
from
March 27, 2021 16:21
993a783
to
43402c5
Compare
tanhauhau
force-pushed
the
tanhauhau/set-context-in-constructor
branch
from
March 27, 2021 16:27
43402c5
to
6d82512
Compare
Conduitry
reviewed
Mar 30, 2021
pfz
pushed a commit
to pfz/svelte
that referenced
this pull request
Apr 25, 2021
Co-authored-by: Conduitry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing in context through the Svelte Component Constructor API
Before submitting the PR, please make sure you do the following
Tests
npm test
and lint the project withnpm run lint