Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): do not warn if href value is dynamic #6110

Merged
merged 3 commits into from
Apr 30, 2021
Merged

fix(a11y): do not warn if href value is dynamic #6110

merged 3 commits into from
Apr 30, 2021

Conversation

thollander
Copy link
Contributor

@thollander thollander commented Mar 21, 2021 •
edited
Loading

Fix getting static value of an attribute returning static value whereas it's dynamic
Simplify rule thanks to the boolean is_static :

  • if an element has dependencies, it will not be static
  • if an element is spread, it is not static too

Closes #5990

@Conduitry Conduitry merged commit 842b841 into sveltejs:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid "A11y: '#' is not a valid href attribute"
2 participants
@thollander @Conduitry