Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix chat link #6976

Merged
merged 2 commits into from
Dec 1, 2021
Merged

[docs] fix chat link #6976

merged 2 commits into from
Dec 1, 2021

Conversation

Conduitry
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

This adds a rel=external to the Discord chat link, which is necessary now that endpoints are no longer handled by the client-side router. It also adds a "the".

@Conduitry Conduitry marked this pull request as draft December 1, 2021 21:07
@Conduitry
Copy link
Member Author

I'd forgotten the main place this needs to be fixed is in the site-kit repo. I'm going to go merge that PR and release that project and bump the version here as part of this PR. Marking as draft.

@Conduitry Conduitry marked this pull request as ready for review December 1, 2021 21:16
@Conduitry Conduitry merged commit fe36911 into sveltejs:master Dec 1, 2021
@Conduitry Conduitry deleted the fix-chat-link branch December 1, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant