Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add referenced for default values in destructuring context #7007

Merged
merged 3 commits into from
Jan 6, 2022

Conversation

tanhauhau
Copy link
Member

Fixes #6964

Marked default values as referenced when destructuring contexts

Before submitting the PR, please make sure you do the following

  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry
Copy link
Member

The test/validator/samples/unreferenced-variables test is failing. I see that this PR removed the expected warnings from what the test is looking for, but it looks like the compiler is still returning a bunch of warnings.

@Conduitry Conduitry marked this pull request as draft December 13, 2021 15:57
@tanhauhau tanhauhau marked this pull request as ready for review December 14, 2021 05:46
@tanhauhau
Copy link
Member Author

oops i think that was removed unintentionally. i've reverted the test case.

@Conduitry Conduitry merged commit 5e40277 into sveltejs:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component props as default values in #each destructuring
2 participants