Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Updated link to the ease visualizer in the docs #7054

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

tylerlwsmith
Copy link
Contributor

@tylerlwsmith tylerlwsmith commented Dec 26, 2021

The docs had a broken link, pointing to /examples#easing instead of /examples/easing.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

The docs had a broken link, pointing to `/examples#easing` instead of `/examples/easing`.
@ignatiusmb
Copy link
Member

Nice catch! Can you also update this while we're at it?

* SSR store handling has been reworked to subscribe and unsubscribe as in DOM mode. SSR stores should work much more consistently now (**3.31.2**, see [custom stores](https://svelte.dev/examples#custom-stores) and [Server-side component API ](https://svelte.dev/docs#run-time-server-side-component-api))

That should cover all links to examples

@tylerlwsmith
Copy link
Contributor Author

Yep, done!

@benmccann benmccann merged commit 84669b5 into sveltejs:master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants