Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Change top level requirement wording #7336

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

TzuHsuan
Copy link
Contributor

@TzuHsuan TzuHsuan commented Mar 3, 2022

Changed the wording to be more consistent between <svelte:window>, <svelte:body> and <svelte:head>.
Chose "may only appear" over "has to appear" as the latter could be misinterpreted as a compulsory element

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Changed the wording to be more consistent between `<svelte:window>`, `<svelte:body>` and `<svelte:head>`.
Chose "may only appear" over "has to appear" as the latter could be misinterpreted as a compulsory element
@tanhauhau tanhauhau merged commit 535a1fc into sveltejs:master Apr 8, 2022
@tanhauhau
Copy link
Member

thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants