Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent boolean attributes breaking shapes inside estree-walker #965

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

Rich-Harris
Copy link
Member

fixes #961

@codecov-io
Copy link

codecov-io commented Nov 27, 2017

Codecov Report

Merging #965 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #965   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         109      109           
  Lines        4054     4054           
  Branches     1301     1301           
=======================================
  Hits         3720     3720           
  Misses        150      150           
  Partials      184      184
Impacted Files Coverage Δ
src/generators/Generator.ts 93.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26be1c...f10e86f. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 3264b51 into master Nov 27, 2017
@Rich-Harris Rich-Harris deleted the gh-961 branch November 27, 2017 13:22
sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
* feat: add stable route for all warning/error codes

This establishes a new route `e/[code]` which serves as a stable reference for all of our warning/error codes. All links to warnings/errors from the Svelte compiler/runtime should go through this route in order to have stable references. That way we can move codes between warnings/errors/different pages or even adjust codes without breaking links.

Part of sveltejs#11305

* prerender entries

* work around Vercel's route limitation

* another workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'dependencies' of undefined
2 participants