refactor: use vitefu to handle svelte libraries #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is vitefu using the exact same createRequire approach to resolve package.json paths? if not this could be a breaking change if it ends up resolving something differently. |
dominikg
reviewed
Oct 29, 2022
|
Currently the only difference is that vitefu uses Other than that, I don't think there's anything else different. The naming conventions such as |
dominikg
reviewed
Nov 7, 2022
dominikg
reviewed
Nov 7, 2022
bluwy
commented
Nov 10, 2022
dominikg
approved these changes
Nov 10, 2022
|
i'll try to add a testcase, afterwards its good to go |
dominikg
requested changes
Nov 10, 2022
bluwy
commented
Nov 11, 2022
| const svelteImportsToInclude = SVELTE_IMPORTS.filter((x) => x !== 'svelte/ssr'); // not used on clientside | ||
| log.debug( | ||
| `adding bare svelte packages to optimizeDeps.include: ${svelteImportsToInclude.join(', ')} ` | ||
| ); | ||
| include.push(...svelteImportsToInclude.filter((x) => !isIncluded(x))); | ||
| include.push(...svelteImportsToInclude); |
There was a problem hiding this comment.
note: I removed this filter as it's fine to include duplicate identifiers
dominikg
approved these changes
Nov 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may have butchered a few debug logs but I'm not sure if there were helpful recently 😬 Tried to preserve most of the code structure as before so it's easier to review.