fix: svelte version detection was broken #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bluwy
approved these changes
Nov 14, 2022
| @@ -43,7 +43,7 @@ async function compileSvelte( | |||
| ): Promise<string> { | |||
| let css = options.compilerOptions.css; | |||
| if (css !== 'none') { | |||
| css = isCssString ? 'inject' : true; | |||
| css = isCssString ? 'injected' : true; | |||
There was a problem hiding this comment.
I missed this too 😅 Didn't expect it to be past-tense.
Comment on lines
-35
to
+36
| return compareToSvelte(version) >= 0; | ||
| const result = compareToSvelte(version) <= 0; | ||
| return result; |
There was a problem hiding this comment.
took me a while to grasp why but makes sense now. nice catch
There was a problem hiding this comment.
still mad at myself for this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#490 introduced svelte version testing that didn't work as desired. inverted the condition and also updated the value used by esbuild plugin to inject css.