Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature - promote prerelease #74

Merged
merged 3 commits into from
May 23, 2023
Merged

feature - promote prerelease #74

merged 3 commits into from
May 23, 2023

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Jun 14, 2022 •
edited
Loading

fix #42 - if release already exists, overwrite name and body if overwrite is set
I also added a new feature: promote that will turn an existing prerelease into a release.

I tested it and it works great

@regevbr
Copy link
Contributor Author

regevbr commented Jun 26, 2022

@svenstaro can you please CR?

@svenstaro
Copy link
Owner

Hey, sorry for the super long wait. Could you rebase this? I'll review quickly after.

@regevbr regevbr force-pushed the body branch 2 times, most recently from b1a5fc3 to ab52748 Compare May 22, 2023 08:02
@regevbr
Copy link
Contributor Author

regevbr commented May 22, 2023

Hey, sorry for the super long wait. Could you rebase this? I'll review quickly after.

Done

@regevbr
Copy link
Contributor Author

regevbr commented May 22, 2023

Noticed that the CI is failing, so I had to remove the make_latest feature as it is no longer supported by github api

@regevbr
Copy link
Contributor Author

regevbr commented May 22, 2023

Sorry for the mess - but I installed the latest version of octokit and fixed make_latest to work with it.
I also added test for promote. The test is not that stable due to GitHub API so I added retries but now everything works

@regevbr
Copy link
Contributor Author

regevbr commented May 22, 2023

@svenstaro not sure why the CI fails, do you have any idea?

@svenstaro
Copy link
Owner

Yeah don't worry about it. It's because the PR runs with your context and you don't have permissions to create a test release in this project.

svenstaro
svenstaro requested changes May 22, 2023
View reviewed changes
Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance you could make the promote feature a separate PR? I think it would be much tidier.

action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@regevbr
Copy link
Contributor Author

regevbr commented May 22, 2023

Is there any chance you could make the promote feature a separate PR? I think it would be much tidier.

sure, sperate what? the dependencies bump and ci fix?

@svenstaro
Copy link
Owner

Is there any chance you could make the promote feature a separate PR? I think it would be much tidier.

sure, sperate what? the dependencies bump and ci fix?

Yes, and also the promote feature.

@regevbr
Copy link
Contributor Author

regevbr commented May 22, 2023

Is there any chance you could make the promote feature a separate PR? I think it would be much tidier.

sure, sperate what? the dependencies bump and ci fix?

Yes, and also the promote feature.

in #104

@regevbr
Copy link
Contributor Author

regevbr commented May 22, 2023

rebased

@svenstaro
Copy link
Owner

Alright, could you still make a separate PR for the promote feature?

@regevbr
Copy link
Contributor Author

regevbr commented May 22, 2023

Alright, could you still make a separate PR for the promote feature?

see #106

@svenstaro
Copy link
Owner

Ok, the other stuff is merged. Needs a new final rebase and a new title and then we should be good and I'll cut a release.

@regevbr regevbr changed the title fix #42 - overwrite body and name as well feature - promote prerelease May 23, 2023
@regevbr
Copy link
Contributor Author

regevbr commented May 23, 2023

Ok, the other stuff is merged. Needs a new final rebase and a new title and then we should be good and I'll cut a release.

rebased

svenstaro
svenstaro requested changes May 23, 2023
View reviewed changes
Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some minor nits.

README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@svenstaro svenstaro merged commit 24bced8 into svenstaro:master May 23, 2023
@svenstaro
Copy link
Owner

Very cool! Merging as-is.

@svenstaro svenstaro mentioned this pull request May 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenstaro svenstaro svenstaro requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how to overwrite body?
2 participants
@regevbr @svenstaro