-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: can i override a node's prefix via criteria ? #852
Comments
Hi @CaptainQuirk thanks for this suggestion. It's not possible (yet), but it makes a lot of sense. Likewise it would probably make more sense to link nodes for node core modules to the node.js documentation. I've made a (quick, very dirty, very non-configurable, not-yet-publishable) hack to gauge the possibilities - example output for the https://sverweij.github.io/examples/dependency-cruiser/links-to-different-targets.html
Questions-> Would this work for you? |
Hi ! Well, that's exactly what I had in mind ! There may be a need for dynamic URL prefixes though: for example, I'm wondering how it would work with custom npm package registries. Gitlab has them. |
The hover feature on this example is great by the way ! |
hmm yeah - configurable makes sense for alternative registries indeed (private or not). + they'll typically be mixed with the public packages from e.g. npmjs. I thought to use fields from package.json (e.g. I'll ponder some solutions to facilitate a split, but I guess as a first step having separate urls for core modules & npm modules would already be an improvement.
Merci :-) It's the result of a little postprocessing on the generated svg - the script to do that is packaged with dependency-cruiser - see doc/cli.md#depcruise-wrap-stream-in-html if you also want to use it. |
I agree with the first step approach ! Having links to the npm registry and the built-in node js module is sufficient for my use cases so far ! |
…re modules (#854) ## Description - for npm modules in the dot reporters link to npmjs.com - for node modules link to nodejs.org ## Motivation and Context Fixes #852 ## How Has This Been Tested? - [x] green ci - [x] additional automated integration tests ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Documentation only change - [ ] Refactor (non-breaking change which fixes an issue without changing functionality) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
@CaptainQuirk the (slightly cleaned up version) of the feature that has separate urls for core & npm modules has been shipped as part [email protected]. |
👍 |
I would like to change the prefix or the href for specific nodes
Summary
prefix
option BUT I would like to be able to link to node packages when the dependency type is npmEnvironment
The text was updated successfully, but these errors were encountered: