Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(depcruise): add license check rules #24

Merged
merged 7 commits into from
Nov 25, 2017

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Nov 25, 2017

Description

  • Adds a 'license' property to cruised modules that have one.
  • Adds 'license' and 'licenseNot' rule elements to enable black- and whitelisting of license types.

Motivation and Context

To be able to flag dependent modules that have licenses that are e.g. not compatible with your own license or with the policies within your company.

(Inspired by https://github.com/franciscop/legally - which scans everything in your module and lists the licenses.)

How Has This Been Tested?

  • Unit tests
  • Dependency-cruiser's own ruleset has a check (it can't use GPL licensed modules as it's MIT licensed and GPL doesn't consider MIT to be compatible with it a.f.a.i.k.).

Types of changes

  • New feature (non-breaking change which adds functionality)
  • 
    

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sverweij sverweij self-assigned this Nov 25, 2017
@sverweij sverweij added the enhancement this will make dependency-cruiser sweeter label Nov 25, 2017
@sverweij sverweij changed the title WIP: feat(depcruise): add license check feat(depcruise): add license check Nov 25, 2017
@sverweij sverweij changed the title feat(depcruise): add license check feat(depcruise): add license check rules Nov 25, 2017
@sverweij sverweij merged commit d35e502 into develop Nov 25, 2017
@sverweij sverweij deleted the feature/add-license-check branch November 25, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement this will make dependency-cruiser sweeter
Projects
Status: released
Development

Successfully merging this pull request may close these issues.

1 participant