Ensure trailing newline is written to files and stdout #879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that a trailing newline is written to files and
stdout
.Description
When writing non-binary output, ensure that a trailing newline is written to files and
stdout
.Motivation and Context
It would be nice to have a trailing newline in the
.dependency-cruiser-known-violations.json
file generated bydepcruise-baseline
for less friction when the file is subsequently consumed by other tools. I believe that something similar applies to other report files generated by dependency cruiser.How Has This Been Tested?
I ran
depcruise-baseline
as a manual test and verified that an additional line feed character gets added to the generated file as a result of this change.I could look into adding an automated test for that, but I have not done that so far. Please let me know in case it is desired.
One of the existing test files needed to be adapted to capture this change, so in that sense it is somewhat covered by existing unit tests.
Types of changes
Checklist
📖
⚖️