Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for svelte 5 #963

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Oct 31, 2024

Description

  • updates the svelte compile call to include an empty object as a 2nd parameter.
    This is required for svelte 5 and svelte 4 seems to ignore it so it seems we're in luck and don't need funky branching.
  • Adjusts the supported compiler range for svelte
  • Adjusts the integration & unit tests to expect svelte 5 output

Motivation and Context

Svelte 5 seems to have become stable and in their release notes they encourage users to upgrade.

Also fixes #962

How Has This Been Tested?

  • green ci
  • adjusted automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the feat/adds-support-for-svelte-5 branch from 4f23756 to d362be9 Compare October 31, 2024 20:34
Copy link

codeclimate bot commented Nov 2, 2024

Code Climate has analyzed commit 3dda11b and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit b473be5 into main Nov 2, 2024
8 checks passed
@sverweij sverweij deleted the feat/adds-support-for-svelte-5 branch November 2, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Svelte 5 support
1 participant