Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adds a 'class' attribute #135

Merged
merged 7 commits into from
Jan 30, 2021
Merged

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jan 27, 2021

Description

  • Adds a 'class' attribute to
    • the smcat language
    • the model
  • Modifies the 'dot' renderer to pass on this class attribute to the generated 'dot' program
  • Modifies the 'dot' renderer to add the current elements defining attributes (in addition to any class explicitly set)
    • for all states: the class state, and its type (e.g. regular, initial, choice, ...) e.g. class="state regular" or when a class klasse gast is explicitly set class="state regular klasse gast"
    • for all transitions: the class transition and when it's explicitly set its type e.g. class="transition external"

TODO:

  • add roundtrip capability for the class attribute (json => smcat)
  • 📖

Published:

Motivation and Context

fixes #134

How Has This Been Tested?

  • automated non-regression tests
  • adapted unit & integration tests
  • new unit tests
  • green ci
  • manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@ghost
Copy link

ghost commented Jan 27, 2021

Congratulations 🎉. DeepCode analyzed your code in 2.135 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@sverweij sverweij force-pushed the feature/adds-class-attribute branch from 8cfa27d to 3fc1a8e Compare January 27, 2021 21:50
- json schema
- peg

- also adds the class attribute to the typescript type definitions
- and unifies the dev graph command to what I'm using on other projects
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5110 lines exceeds the maximum allowed for the inline comments feature.

@sverweij sverweij force-pushed the feature/adds-class-attribute branch from 0974887 to ef66d41 Compare January 30, 2021 18:02
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5204 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5220 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5228 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Jan 30, 2021

Code Climate has analyzed commit 6d1200d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit 684d684 into develop Jan 30, 2021
@sverweij sverweij deleted the feature/adds-class-attribute branch January 30, 2021 20:22
@mwaddell mwaddell mentioned this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional "class" attribute to nodes and links - improved styling and interactivity
1 participant