Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scxml): replaces 'traverse' with 'neotraverse' #220

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

sverweij
Copy link
Owner

Description

  • replaces traverse with neotraverse

Motivation and Context

Bumping traverse to latest yields inexplicable error messages. neotraverse - which seems to be actively maintained - doesn't + is ESM only

How Has This Been Tested?

  • green ci
  • working version of the on-line interpreter

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the refactor/replace-traverse-with-neotraverse branch from 6eb6af9 to ccae3ae Compare December 22, 2024 17:35
Copy link

codeclimate bot commented Dec 22, 2024

Code Climate has analyzed commit ccae3ae and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit 352b8eb into main Dec 22, 2024
11 checks passed
@sverweij sverweij deleted the refactor/replace-traverse-with-neotraverse branch December 22, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant