Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(types|api): describe how to add a renderer, more strongly type definitions in /types, brush-up of the api doc #62

Merged
merged 2 commits into from
Jul 28, 2019

Conversation

sverweij
Copy link
Owner

Description, Motivation and Context

See title - helps with ease of use and maintenance

How Has This Been Tested?

  • spell checker
  • re-reading
  • squinting at the text
  • manually testing the types with an ide

Screenshots (if appropriate):

Types of changes

  • Δ Documentation

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2019

Code Climate has analyzed commit 0381e40 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit e7fe322 into develop Jul 28, 2019
@sverweij sverweij deleted the doc/type-and-api-documentation branch July 28, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant