Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(parse-scxml): set typeExplicitlySet when the type cannot be derived from the state's name #69

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Aug 2, 2019

Description

See title

Motivation and Context

So on round tripping to other formats (i.e. smcat) the type information doesn't get lost

How Has This Been Tested?

  • modified integration test case
  • automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…rived from the state's name

so on round tripping to other formats (i.e. smcat) the type information doesn't get lost
@codeclimate
Copy link

codeclimate bot commented Aug 2, 2019

Code Climate has analyzed commit 4310bf0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit 75d2761 into develop Aug 2, 2019
@sverweij sverweij deleted the bugfix/scxml-set-typeExplicitlySet-attribute branch August 2, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant