Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(dot): heed the passed node color #77

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

sverweij
Copy link
Owner

Description

When passing a node color (either on cli via --dot-node-attrs, via the API with dotNodeAttrs or on the on line interpreter via the query parameters) on pseudo states also use that as the fill color.

Motivation and Context

Looks better.

How Has This Been Tested?

  • additional integration test
  • automated non-regression tests

Screenshots

before

image

after

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

src/render/dot/state-transformers.js Show resolved Hide resolved
src/render/dot/utl.js Show resolved Hide resolved
src/render/dot/utl.js Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 20, 2019

Code Climate has analyzed commit 3eda5a3 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit 6f5b436 into develop Aug 20, 2019
@sverweij sverweij deleted the feature/heed-passed-node-color branch August 20, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant