Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(site): add png export to on line playground #79

Merged
merged 10 commits into from
Sep 8, 2019

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Sep 6, 2019

Description

  • Adds a quick and simple export to png & svg to the online interpreter.

Motivation and Context

  • Easier than making screenshots

How Has This Been Tested?

  • with eyeballs

(the online interpreter should b.t.w. graduated to use a normal framework like react/ vue/ svelte some day, to make it easier to test & maintain)

Screenshot

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • [/] I have added tests to cover my changes.
  • All new and existing tests passed.

@codeclimate
Copy link

codeclimate bot commented Sep 6, 2019

Code Climate has analyzed commit 199ada1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit dd68ff4 into develop Sep 8, 2019
@sverweij sverweij deleted the feature/add-png-export-to-playground branch September 8, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant