Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scxml): use lodash.castArray instead of hand rolled utility #80

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

sverweij
Copy link
Owner

Description, Motivation and Context

See title. Reduces maintenance effort.

How Has This Been Tested?

  • automated non-regression tests

Types of changes

  • Refactor (non-breaking change which fixes an issue)

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codeclimate
Copy link

codeclimate bot commented Sep 13, 2019

Code Climate has analyzed commit 372532f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit 90e30fc into develop Sep 13, 2019
@sverweij sverweij deleted the refactor/replace-arrayify-with-lodash-castarray branch September 13, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant