Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(cli): document viz.js warning on node 12 #87

Merged
merged 4 commits into from
Oct 12, 2019

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Oct 8, 2019

Description

  • in the readme document the occurrence of a warning message on the command line
  • add a faq document
  • in the cli do the same (conditionally, only when relevant; when node version >= 12)

Motivation and Context

How Has This Been Tested?

  • README: by applying eye balls
  • cli: additional unit test(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sverweij sverweij force-pushed the doc/warn-about-viz-warning branch from da89bfc to 5f0c677 Compare October 8, 2019 20:15
@sverweij sverweij changed the title WIP: doc(README): document viz.js warning in the cli WIP: doc(cli): document viz.js warning on node 12 Oct 8, 2019
@codeclimate
Copy link

codeclimate bot commented Oct 11, 2019

Code Climate has analyzed commit 3d43a9f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij changed the title WIP: doc(cli): document viz.js warning on node 12 doc(cli): document viz.js warning on node 12 Oct 12, 2019
@sverweij sverweij merged commit f4679c7 into develop Oct 12, 2019
@sverweij sverweij deleted the doc/warn-about-viz-warning branch October 12, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken dependency viz.js – "Invalid asm.js: Function definition doesn't match use"
1 participant