Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page management functions #14

Merged
merged 32 commits into from
Nov 24, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 24, 2024

This PR adds new page management functionality and improves test robustness in ChromeDevToolsLite.

Changes:

  • Implemented get_all_pages and new_page functions
  • Added comprehensive page management tests
  • Improved test robustness and error handling
  • Enhanced Chrome process management
  • Added retry mechanisms for test setup
  • Improved wait conditions for page loads
  • Refactored core functionality to use WSClient consistently
  • Added browser context support
  • Updated CI workflow

Testing:

  • Added new test files:
    • test/page_management_test.jl
    • test/browser_test.jl
    • test/page_test.jl
  • Enhanced existing test files with better error handling
  • All tests passing locally

Link to Devin run: https://preview.devin.ai/devin/3f64e5bc3b894e409ed28f8d770e030f

devin-ai-integration bot and others added 30 commits November 23, 2024 22:14
- Implement mouse control (click, double-click, move, position)
- Add keyboard input support (key press, modifiers)
- Create comprehensive test suite
- Add example demonstrating input control features
- Implement get_element_position function
- Update mouse position tracking
- Add comprehensive tests for input controls
- Fix click implementation with proper event sequencing
- Add Documenter dependency
- Reorganize exports
- Add Page type and send_command utility
- Update module structure
- Remove duplicate function definitions in page.jl
- Add goto and close methods for Browser type
- Add Browser struct to types.jl
- Add get_all_pages and new_page functions
- Add comprehensive page management tests
- All functions properly exported in main module
- Enhanced Chrome process management and cleanup
- Added retry mechanisms for test setup
- Improved wait conditions for page loads
- Better error handling in WebSocket tests
- Updated test cleanup procedures
- Update WSClient to handle browser functionality
- Remove Browser struct references
- Add browser context support
- Improve WebSocket connection handling
- Remove Browser struct references from tests
- Add browser context tests
- Update input and element tests for new structure
@svilupp svilupp merged commit ab275fb into main Nov 24, 2024
0 of 3 checks passed
@svilupp svilupp deleted the devin/1732438945-page-management-functions branch November 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant