python3.7 and pyroute2

[fedya]

-bash-4.4$ /usr/bin/mock -v --configdir=/etc/mock/ --buildsrpm --spec=/home/omv/htop/htop.spec --sources=/home/omv/htop --no-cleanup-after --resultdir=/home/omv/output
Traceback (most recent call last):
  File "/usr/libexec/mock/mock", line 79, in <module>
    from mockbuild import util
  File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 41, in <module>
    from pyroute2 import IPRoute
  File "/usr/lib/python3.7/site-packages/pyroute2/__init__.py", line 19, in <module>
    from pyroute2.iproute import (IPRoute,
  File "/usr/lib/python3.7/site-packages/pyroute2/iproute.py", line 230, in <module>
    from pyroute2.netlink.rtnl.iprsocket import IPRSocket
  File "/usr/lib/python3.7/site-packages/pyroute2/netlink/rtnl/iprsocket.py", line 49
    def bind(self, groups=rtnl.RTNL_GROUPS, async=False):
                                                ^
SyntaxError: invalid syntax

[vodik]

Yeah, async is a keyword now.

[svinota]

A good question, what to do now without breakin' all the things.

(3.8) [peet@svinosund pyroute2] {master} $ flake8 pyroute2/
pyroute2/devlink.py:20:19: E999 SyntaxError: invalid syntax
pyroute2/iwutil.py:156:19: E999 SyntaxError: invalid syntax
pyroute2/netlink/nlsocket.py:929:44: E999 SyntaxError: invalid syntax
pyroute2/netlink/nl80211/__init__.py:641:34: E999 SyntaxError: invalid syntax
pyroute2/netlink/generic/__init__.py:29:62: E999 SyntaxError: invalid syntax
pyroute2/netlink/rtnl/iprsocket.py:49:49: E999 SyntaxError: invalid syntax
pyroute2/netlink/rtnl/riprsocket.py:13:49: E999 SyntaxError: invalid syntax
pyroute2/netlink/devlink/__init__.py:129:34: E999 SyntaxError: invalid syntax
pyroute2/netlink/event/__init__.py:21:34: E999 SyntaxError: invalid syntax
pyroute2/ipdb/main.py:866:59: E999 SyntaxError: invalid syntax

First, I plan to add an alias to that argument and raise a deprecation warning in the case of the keyword usage. And let's hope 3.7 will not come too soon, so everyone will have time to fix own code in the case the keyword is used.

[hroncok]

Hi. Any update on this? Do you need help? 3.7 is approaching and we would like to have it in Fedora soon, but this would block us.

[hroncok]

Workaround from OpenMandriva: https://github.com/OpenMandrivaAssociation/python-pyroute2/blob/master/pyroute2-0.4.21-python-3.7.patch

[svinota]

@hroncok yep, will be fixed asap in the master branch.

[hroncok]

Oh I see now you are the Fedora maintainer and upstream owner as well. Excellent!

[hroncok]

I have an idea about a decorator that might help... give me a minute.

[hroncok]

import functools
import warnings


def deprecated_async(func):
    @functools.wraps(func)
    def inner(*args, **kwargs):
        if 'async' in kwargs:
            if 'async_' in kwargs:
                raise ValueError('cannot use both async and async_ keyword '
                                 'arguments! the latter obsoletes the first.')
            warnings.warn('async keyword argumnt is deprecated, use async_ '
                          'instead', DeprecationWarning)
            kwargs['async_'] = kwargs['async']
            del kwargs['async']
        return func(*args, **kwargs)
    return inner


@deprecated_async
def foo(a, b, async_):
    return a, b, async_


print(foo(1, 2, async_=True))
print(foo(1, 2, async=True))

[hroncok]

May I submit a PR in this manner?

[svinota]

Sorry, was busy testing another change

Almost the same idea, but w/o a decorator

[hroncok]

Whatever works for you. The decorator was there because of DRY.

[svinota]

@hroncok btw do you know anyone who could become the package maintainer in RH? I have almost no time to update the package as new releases of the library come, so it's quite ancient in the Fedora repo

[hroncok]

You mean if a redhatter could help you maintain the package in Fedora? Since mock requires this, I guess @xsuchy should be able to get someone. Also don't hesitate to make the python-sig FAS group an admin.

[svinota]

Ok, I do that now.

Another question — does it wait until the next weekend (10.06) to cut the next release? Or to release asap?

[svinota]

@hroncok I made the python-sig group admin on the https://src.fedoraproject.org/rpms/python-pyroute2 , thanks for the hint

[hroncok]

does it wait until the next weekend (10.06) to cut the next release

Yes. if not, I can always take the patch and apply it in Fedora.

Thanks

[svinota]

@hroncok ping me pls if there will be any issues or if the release will be needed earlier.

Thanks