feat(redis): add "pending" task to re-queue unhandled messages #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-onelson
force-pushed
the
onelson/redis-pending-task
branch
from
7b762c3 to
7cb5316
Compare
svix-onelson
changed the title
|
Leaving this as a draft until I add some tests to show this actually works, as well as resolve some of the FIXMEs sprinkled throughout. Most of the open questions relate to exposing things via config and similar. |
svix-onelson
force-pushed
the
onelson/redis-pending-task
branch
2 times, most recently
from
8a8b0c6 to
f432b32
Compare
In svix-server's redis queue implementation, there's a spawned task to look for messages that have been "claimed" (i.e. pulled off the queue) but not ack'd or nack'd within some deadline period. This was missing from the omniqueue version, added in this diff. This refactors the prior background task spawned for delayed messages so it and the new one for the pending sweeper are bundled together in a `JoinSet`. Since dropping a `JoinSet` means the spawned tasks under it will abort, the handle is now held by any consumers/producers that share the same config.
svix-onelson
force-pushed
the
onelson/redis-pending-task
branch
from
f432b32 to
232f1e8
Compare
svix-onelson
changed the title
svix-james
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In svix-server's redis queue implementation, there's a spawned task to look for messages that have been "claimed" (i.e. pulled off the queue) but not ack'd or nack'd within some deadline period.
This was missing from the omniqueue version, added in this diff.
This refactors the prior background task spawned for delayed messages so it and the new one for the pending sweeper are bundled together in a
JoinSet.Since dropping a
JoinSetmeans the spawned tasks under it will abort, the handle is now held by any consumers/producers that share the same config.